-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #1365
Conversation
@ulgens I guess tests are failing |
#1368 should fix all the failed tests. |
@firaskafri Are these close - reopens are on purpose or do we have a bug on Github's side? |
@ulgens something is wrong with tests other than the failures, closed and reopened the PR to trigger them |
@firaskafri Please don't 🙂 . It creates misleading notifications for anyone following the PR and doesn't make much on fixing the issue. I'll check this one on the weekend. |
The test pipeline gets stuck sometimes and that is unrelated to the the actual code failure, that was the quick way to re trigger the tests. Any suggestions to fix this? |
@firaskafri Failing tasks have "re-run" option on their Actions page. I believe it gives a cleaner result. |
Tests look a bit better now. I'll check that last failing test as soon as possible. |
@ulgens test for 3.11 are failing |
It seems that Schema() behavior changes when using python 3.11 which is breaking 3.11 tests. I could pin point the issue in enums: In python 3.11, schema generates this:
While in older python versions:
|
it seems that |
Thanks for the fix guys. I rebased the branch for clarity. |
Glad to see you back @ulgens ! |
* Add support for Python 3.11 * Fix Python 3.11 compatibility matrix * Add temporary fix for default enum description --------- Co-authored-by: Firas Kafri <[email protected]>
No description provided.