Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility with Django 4.0 and 4.1 #191

Merged
merged 10 commits into from
Jan 12, 2023
Merged

Add compatibility with Django 4.0 and 4.1 #191

merged 10 commits into from
Jan 12, 2023

Conversation

washeck
Copy link
Contributor

@washeck washeck commented Dec 9, 2022

This PR is mainly based on #181 but I tried to make it in such a way that GitHub actions passes so it can be merge with no additional work.

washeck and others added 7 commits December 8, 2022 09:56
@washeck
Fix TypeError in directives import
6834767 
Commit b9423b74ca9d22d009a1a4633b38b2bcd06c604b in graphql-core
changed specified_directives from FrozenList to Tuple making
it impossible to concatenate with list.
@keithhackbarth @washeck
Always add registry to _meta as its needed now in the new filterset
9a844d9
@keithhackbarth @washeck
Replace force_text with force_str to support Django 4
ddd57f3
@washeck
Add Django 3.2,4.0 and 4.1 to tox
f8ed6a6
@keithhackbarth @washeck
IPDB: Upgrade to fix compliant about 2_to_3 being invalid in newer ve…
76645a4 
…rsion of setup tools
@washeck
Update drf and pytest dependencies
3ecdba3 
- djangorestframework version specifier "^no" was not valid
- fix pytest error by upgrading to the latest version supporting
  python3.6
  (TypeError: required field "lineno" missing from alias)
@washeck
Remove Python 3.6 support as it is EOL'ed
e568e5a
@washeck
Use allowlist instead of whitelist in tox
908fc1b 
as tox changed the naming.
@washeck
Update black to fix run on python 3.9
f446a77 
and remove forgotten python 3.6 requirement as it conflicts
with the latest black.
@washeck
Add oficial Python 3.10 support, remove EOL'ed versions
3048c7f 
and simplify tox environment configuration to be more maintenable.
@washeck washeck mentioned this pull request Dec 9, 2022
Open
@andrei-shabanski
Copy link

@washeck Thank you for your PR! Now it's the only way to use this package with django 4.

I think it's worth checking out the PR with python 3.11. Can you update tox and CI configs to run tests on python 3.11?

@washeck
Copy link
Contributor Author

washeck commented Jan 12, 2023

Actually, I thought it would be easier to add python 3.11 after it is added to graphene-django itself, see graphql-python/graphene-django#1365

@andrei-shabanski
Copy link

I didn't notice that. Agree with you

One more question about django-filter. graphene-django tests are run with django-filter>=22.1. However, graphene-django-extras still requires django-filter >=2.2.0, <3.

It seems that django-filter 22.1 doesn't have major changes since 2.2.0. Mainly, they removed outdated warnings and switched to a two-part versioning scheme. The latter doesn't allow to install the latest version django-filter with graphene-django-extras in the same project.

Does it make sense to upgrade django-filter version in pyproject.toml up to 22.1?

@eamigo86 eamigo86 merged commit 84ba26e into eamigo86:master Jan 12, 2023
@washeck washeck deleted the django40 branch January 12, 2023 10:57
@bernardopericacho
Copy link
Contributor

I didn't notice that. Agree with you

One more question about django-filter. graphene-django tests are run with django-filter>=22.1. However, graphene-django-extras still requires django-filter >=2.2.0, <3.

It seems that django-filter 22.1 doesn't have major changes since 2.2.0. Mainly, they removed outdated warnings and switched to a two-part versioning scheme. The latter doesn't allow to install the latest version django-filter with graphene-django-extras in the same project.

Does it make sense to upgrade django-filter version in pyproject.toml up to 22.1?

I hit this when trying to install from master branch

 poetry add git+ssh://[email protected]:eamigo86/graphene-django-extras.git#master 

Updating dependencies
Resolving dependencies... (8.1s)

  SolverProblemError

  Because graphene-django-extras (rev master) depends on django-filter (^2.2.0)
   and oddsjam-backend depends on django-filter (^21.1), graphene-django-extras is forbidden.
  So, because oddsjam-backend depends on graphene-django-extras (rev master), version solving failed.

@bernardopericacho bernardopericacho mentioned this pull request Jan 23, 2023
Merged
@sjdemartini sjdemartini mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@washeck @andrei-shabanski @bernardopericacho @eamigo86 @keithhackbarth