enhance(eslint-plugin): refactor the parts using tools #564
Conversation
🦋 Changeset detectedLatest commit: 5af1025 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as alpha in npm (based on the declared |
| return null; | ||
| } | ||
|
|
||
| if (schemaCache.has(schemaKey)) { |
There was a problem hiding this comment.
Using get once will be better for performance
| if (!siblings) { | ||
| const documents = projectForFile.loadDocumentsSync(projectForFile.documents, { | ||
| skipGraphQLImport: true, | ||
| cache: loaderCache |
There was a problem hiding this comment.
This might improve the performance a bit as well and remove the need of schemaCache and operationsCache
| node.operationTypes.forEach(collect); | ||
| }, | ||
| ObjectTypeDefinition(node) { | ||
| [node, ...node.interfaces].forEach(collect); |
There was a problem hiding this comment.
This will reduce the number of iterations
| const astNode = parse(printedSchema); // Transforms the string into ASTNode | ||
| const cache = Object.create(null); | ||
|
|
||
| const astNode = getDocumentNodeFromSchema(schema); // Transforms the schema into ASTNode |
There was a problem hiding this comment.
printSchemaWithDirectives also uses this function and no need to do print and parse again.
ardatan
force-pushed
the
refactor-graphql-tools-usage
branch
from
3bcc1a7 to
5af1025
Compare
ardatan
requested review from
dimaMachina and
dotansimha
and removed request for
dimaMachina
3 participants
This PR also adds
loaderCachethat removes the need ofschemaCacheandoperationsCachebut I didn't remove it in this PR because it seems to need more changes than removing them.