Skip to content

Conversation

@dimaMachina
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dotansimha
Copy link
Member

Thanks @B2o5T !

Just small note, we are using changesets for managing releases and changelogs, so please make sure to add a changeset file in each PR (Run yarn changeset and it will guide you). I added one for this PR ;)

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2021

🦋 Changeset detected

Latest commit: 0f2bdeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha dotansimha merged commit 45acfde into graphql-hive:master May 19, 2021
@dimaMachina
Copy link
Contributor Author

Thanks @B2o5T !

Just small note, we are using changesets for managing releases and changelogs, so please make sure to add a changeset file in each PR (Run yarn changeset and it will guide you). I added one for this PR ;)

Thanks @dotansimha, Have you thought about to add yarn changeset to your husky pre-commit hook?

@dotansimha
Copy link
Member

Thanks @B2o5T !

Just small note, we are using changesets for managing releases and changelogs, so please make sure to add a changeset file in each PR (Run yarn changeset and it will guide you). I added one for this PR ;)

Thanks @dotansimha, Have you thought about to add yarn changeset to your husky pre-commit hook?,

Actually, we prefer it to be manual because it's a blocking action (it wait for user input), and running this as a hook will break VSCode and other editors that commit behind the scenes. We also prefer manually because it asks you to describe your changes, and choose a version bump matching your changes (patch/minor/major).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants