[response-cache] deprecate ttlPerType option in favor of ttlPerSchemaCoordinate#2258
Merged
EmrysMyrddin merged 3 commits intomainfrom Sep 18, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: c72a736 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dotansimha
approved these changes
Jun 30, 2024
3e0ba79 to
c72a736
Compare
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@envelop/core |
5.3.2-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
@envelop/parser-cache |
9.0.1-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
@envelop/rate-limiter |
8.1.0-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache |
8.1.0-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache-cloudflare-kv |
5.0.0-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
@envelop/validation-cache |
9.0.1-alpha-20250918085541-5962be2abda141945eadaab994550538c48928e5 |
npm ↗︎ unpkg ↗︎ |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://7b49e85f.envelop.pages.dev |
Collaborator
✅ Benchmark Results |
n1ru4l
approved these changes
Jul 11, 2024
Contributor
Author
|
I just realized that I didn't updated tests. I have to do this before merging. |
c72a736 to
1cc771a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an incoherence in the options API. TTL is configured using 2 parameters:
ttlPerTypeandttlPerSchemaCoordinatewhile scope is configured only viascopeBySchemaCoordinatewhich can contain typeName only or typeName+fieldName keys.This PR is deprecating the
ttlPerTypein favor ofttlPerSchemaCoordinateto be more coherent.ttlPerTypeis still supported but will be removed in future major release.Type of change