Use http.Request.Context() instead of context.Background() #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of using context.Background(), Handler.ServeHTTP provide r.Context() to Handler.ContextHandler(). This will allow users to pass context with idomatic middleware framework like [interpose](https://github.com/carbocation/interpose) and [chi](https://github.com/go-chi/chi).
|
Seems like a duplicate of #24. Close now. |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better interoperate with middleware frameworks, it makes more sense to pass the http.Request's context instead of a context.Background(). That way user may better control the query with deadline, or inject dataloader from outside the Handler.
Also bumped the travis test versions and include go1.8.