Skip to content

Conversation

@0x616E676572
Copy link
Contributor

The idea behind this is that if I use standard http mux with a middleware, for an example, to set currently authenticated user into the request's context it's not working as expected

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 94.444% when pulling 577a782 on 0x616E676572:request_context into 37fc9f5 on graphql-go:master.

@chris-ramon
Copy link
Member

chris-ramon commented Aug 23, 2017

lgtm 👍 , request.Context() defaults to context.Background(), so better use the request one; thanks a lot @0x616E676572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants