Skip to content

Conversation

@chris-ramon
Copy link
Member

Overview

  • vendor: removes vendor directory, until now we were using two dependencies:
    • https://github.com/kr/pretty - for debugging, to check diff from expect & actual tests, we can always use this awesome lib, when working on this lib for debugging.
    • golang.org/x/net/context" - for context support, but dependency was removed via: Use standard library's "context" package #214, since go1.7+ included in the std lib.
  • testutil: updated Diff, to just return want & got, instead of the actual diff, now output looks like this, Eg:
--- FAIL: TestBasicGraphQLExample (0.00s)
        graphql_test.go:131: wrong result, query: { hello }, graphql result diff: [
                got: &{map[hello:world] []}
                want: map[hello:worldz]
                ]

Test plan

  • go test ./...

kr/pretty was pretty useful for debugging,
we can always use this locally, not need to depend on it.

x/net/context was included on go std lib,
since go1.7+ which is the lowest supported version.
@chris-ramon chris-ramon mentioned this pull request Jul 23, 2017
1 task
@chris-ramon chris-ramon merged commit 3442aeb into master Jul 23, 2017
@chris-ramon chris-ramon deleted the no-dependencies branch July 23, 2017 02:29
@coveralls
Copy link

coveralls commented Jul 23, 2017

Coverage Status

Coverage increased (+0.03%) to 82.129% when pulling 439c1ad on no-dependencies into a498c85 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants