Skip to content

Conversation

@exklamationmark
Copy link
Contributor

@exklamationmark exklamationmark commented Jul 16, 2017

While going through the source code, I noticed that it's still using golang.org/x/net/context.

This could be swapped with golang.org/pkg/context without any further code changes. However, this mean the package would need Go 1.7+ to work.

wdyt?

@coveralls
Copy link

coveralls commented Jul 16, 2017

Coverage Status

Coverage remained the same at 82.129% when pulling a5f1028 on exklamationmark:refactor/context into 3e619b6 on graphql-go:master.

@exklamationmark
Copy link
Contributor Author

This should address #212

@coveralls
Copy link

coveralls commented Jul 18, 2017

Coverage Status

Coverage remained the same at 82.129% when pulling d46ea7e on exklamationmark:refactor/context into 096f5bc on graphql-go:master.

@chris-ramon
Copy link
Member

chris-ramon commented Jul 23, 2017

lgtm 👍 — thanks a lot @exklamationmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants