-
Notifications
You must be signed in to change notification settings - Fork 228
cli: fixes dep error from ipfs-http-client and concat-stream #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: fixes dep error from ipfs-http-client and concat-stream #1263
Conversation
🦋 Changeset detectedLatest commit: fbe3ee4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch works in my monorepo for the time being. Thanks for pulling this together. I suggest we upgrade the package entirely — it was published 4 years ago — to avoid this technical debt.
@adamazad FWIW I tried to upgrade the package, but because new versions of Although pushing this patch as early as the team can would be a great help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's patch this for now and definitely need to move away from this
thank you @mihirgupta0900! |
doesn't look like this worked in |
not work in [@graphprotocol/[email protected]] either |
fixes #1262
I have forked the
concat-stream
repository and have patched it with the changes that existed in the other forked version. This is definitely a "patch" and I think there needs to be a better solution to fix this issue.Ideally the version for
ipfs-http-client
is upgraded to the latest version along with any changes that are required