Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft-Comp #835

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Draft-Comp #835

wants to merge 2 commits into from

Conversation

idalithb
Copy link
Contributor

  • first copy of comp

@idalithb idalithb requested a review from incrypto32 December 11, 2024 23:12
@idalithb idalithb changed the title Draft 1 Draft-Comp Dec 11, 2024
incrypto32
incrypto32 requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@incrypto32 incrypto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some minor comments about the chain mismatch in the example which is my mistake - i had the wrong chain in the example subgraph which i have now updated. Would be great to address that.

website/pages/en/cookbook/subgraph-composition.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/subgraph-composition.mdx Outdated Show resolved Hide resolved
@idalithb idalithb requested a review from incrypto32 January 14, 2025 01:21
incrypto32
incrypto32 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@incrypto32 incrypto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incrypto32 incrypto32 incrypto32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idalithb @incrypto32