Skip to content

Conversation

@tmigone
Copy link
Member

@tmigone tmigone commented Sep 2, 2022

This PR cherry picks commits from the following L2 related branches into dev:

It's mostly tooling changes that have been reviewed in #670

@tmigone tmigone changed the title Tmigone/sync l2 testnet Sync l2-testnet / scenario1 to dev Sep 2, 2022
@tmigone tmigone requested a review from abarmat September 2, 2022 09:53
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #703 (397bcac) into dev (f9deb7b) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #703      +/-   ##
==========================================
+ Coverage   90.35%   90.57%   +0.22%     
==========================================
  Files          35       35              
  Lines        1762     1762              
  Branches      296      296              
==========================================
+ Hits         1592     1596       +4     
+ Misses        170      166       -4     
Flag Coverage Δ
unittests 90.57% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/rewards/RewardsManager.sol 100.00% <0.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tmigone tmigone changed the title Sync l2-testnet / scenario1 to dev Sync: l2-testnet / scenario1 > dev Sep 5, 2022
@tmigone tmigone mentioned this pull request Sep 5, 2022
2 tasks
@tmigone tmigone requested a review from pcarranzav September 5, 2022 14:49
pcarranzav
pcarranzav previously approved these changes Sep 5, 2022
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments (that can be addressed separately), but LGTM 👍

@tmigone tmigone merged commit 07c0790 into dev Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants