Skip to content

Conversation

@tmigone
Copy link
Member

@tmigone tmigone commented Aug 4, 2022

This PR implements step 1.2 on the L2 validation plan with a script plus a test file that can be run to assert the scenario.

This scenario sets up and tests the following:

  • two indexers with stake
  • each indexer has two or three allocations, one of which is open
  • four subgraphs, with 0, 400, 10000 and 12500 tokens signalled, with signal coming from three different curators

@tmigone tmigone changed the base branch from dev to l2-testnet August 4, 2022 10:00
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #670 (9395f65) into l2-testnet (3a22a27) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           l2-testnet     #670   +/-   ##
===========================================
  Coverage       92.13%   92.13%           
===========================================
  Files              44       44           
  Lines            2137     2137           
  Branches          370      370           
===========================================
  Hits             1969     1969           
  Misses            168      168           
Flag Coverage Δ
unittests 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tmigone tmigone force-pushed the tmigone/scenario1 branch from 86e8495 to 1b47e88 Compare August 4, 2022 13:58
@tmigone tmigone requested a review from abarmat August 4, 2022 14:00
Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good, I left a few comments.

@tmigone
Copy link
Member Author

tmigone commented Aug 23, 2022

@abarmat I'll work on addressing your comments but I think you didn't review the latest commit, I think you were on 6087247 (see https://github.com/graphprotocol/contracts/pull/670/commits). I only noticed because there are two later commits that refactor the scenario1 into more generic and re-usable parts.

@tmigone tmigone changed the base branch from l2-testnet to tmigone/sync-l2-testnet September 1, 2022 14:54
@tmigone tmigone changed the base branch from tmigone/sync-l2-testnet to l2-testnet September 1, 2022 14:55
@tmigone
Copy link
Member Author

tmigone commented Sep 1, 2022

@abarmat, I'll reply to your comments now. Note that you didn't review the latest commit but an intermediate one. Some of your comments were addressed by later commits.

In any case, since this PR is L1 exclusive and not using any of the new L1 features (reservoir, gateway) I'm cherry picking these commits into dev on a separate PR so I'll close this one.

@tmigone
Copy link
Member Author

tmigone commented Sep 2, 2022

Commits from this PR have been cherry picked into #703
Closing PR.

@tmigone tmigone closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants