Skip to content

Conversation

@belijzajac
Copy link
Collaborator

@belijzajac belijzajac commented Feb 17, 2023

This PR updates the interface following the c-kzg-4844 changes.

  • Update c-kzg-4844 git hash to 1493f2b
  • Add Go binding
  • Hook up C tests from c-kzg-4844
  • Benchmarks for the mcl backend
  • Refactor and clean up code

@belijzajac belijzajac self-assigned this Feb 17, 2023
@sauliusgrigaitis sauliusgrigaitis mentioned this pull request Mar 3, 2023
@nazar-pc
Copy link
Contributor

nazar-pc commented Mar 3, 2023

Is there anything in particular left to be done in this PR before landing into main?

@belijzajac
Copy link
Collaborator Author

Basically these three points:

  • Update the c-kzg-4844 git hash that is now 3 weeks old
  • Update blst-from-scratch and mcl implementations following the c-kzg-4844 changes
  • Make zkcryto and arkworks eip-4844 compliant (these can be lengthy processes that can be done by separate PRs)

@sauliusgrigaitis
Copy link
Member

I think zkcrypto and arkworks can wait, even mcl can wait if it takes too long.

@belijzajac
Copy link
Collaborator Author

This is the last version that supports aggregate KZG proofs.

The 6 functions that made into proposal (ethereum/consensus-specs#3274 (comment)) require us to rewrite a significant amount of logic (commits: c9e7b65, aee67f6, 48c3cb5; CI: jobs/7632143695 and jobs/7631881052), effectively deprecating the majority of 4844 tests and benchmarks.

@belijzajac belijzajac marked this pull request as ready for review March 9, 2023 13:48
@belijzajac belijzajac merged commit 7eb52ca into main Mar 9, 2023
@belijzajac belijzajac deleted the update_upstream branch March 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants