Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking CI is still running in my fork, but the other one finished successfully.
This PR tries to make code more idiomatic in Rust in a few ways:
fn default()in some trait replaced with dependency on standardDefaulttrait with corresponding re-duplicationThe only non-equivalent change is that this was effectively replaced with
Self::new(0):There was already
Defaultwas already derived forLPolyautomatically (with empty coefficients, naturally). In this self-conflicting situation I decided to prefer derived implementation since that is how other implementations are done too.The rest of changes are mechanical even though API has changed slightly.
There are absolutely still things to improve, but I think this is a decent progress deserving its own PR.