Chore: Use gRPC packages from dskit #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Sep 10, 2021
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
LGTM. Should be good to go after rebasing on top of master.
Contributor
Author
@pstibrany thanks, but the corresponding PR to dskit needs merging first :) This is just a draft PR in the meantime. |
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
2 times, most recently
from
9e4907f to
6a22da4
Compare
pracucci
approved these changes
Sep 23, 2021
Collaborator
|
@aknuds1 PR LGTM. Could you rebase and mark it ready for review, please? If no other significant change is done, then we can merge once CI passes. |
Contributor
Author
|
@pracucci thanks, but we need to merge the corresponding PR in dskit first. Could you answer this question on it? |
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
6a22da4 to
d22cd84
Compare
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
d22cd84 to
aa588f0
Compare
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
2 times, most recently
from
9037a98 to
90147ce
Compare
aknuds1
changed the title
Contributor
Author
|
@pracucci it should be ready to merge now :) |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
90147ce to
b228315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use gRPC packages from dskit instead of pkg/util/grpc*.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]