Skip to content

ruler: report failed eval on any 5xx status #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

ruler: report failed eval on any 5xx status #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b86df0
ruler: report failed eval on any 5xx status
ortuman Jun 8, 2022
ec1ca9f
addressed PR suggestion
ortuman Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
* [BUGFIX] Ring: fix bug where instances may appear unhealthy in the hash ring web UI even though they are not. #1933
* [BUGFIX] API: gzip is now enforced when identity encoding is explicitly rejected. #1864
* [BUGFIX] Fix panic at startup when Mimir is running in monolithic mode and query sharding is enabled. #2036
* [BUGFIX] Ruler: report failed evaluation metric for any 5xx status code returned by the query-frontend when remote operational mode is enabled. #2053

### Mixin

Expand Down
5 changes: 2 additions & 3 deletions pkg/ruler/compat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ package ruler
import (
"context"
"errors"
"net/http"
"time"

"github.com/go-kit/log"
Expand Down Expand Up @@ -151,9 +150,9 @@ func MetricsQueryFunc(qf rules.QueryFunc, queries, failedQueries prometheus.Coun
return result, origErr

} else if err != nil {
// When remote querier enabled, only consider failed queries those returning a 500 status code.
// When remote querier enabled, only consider failed queries those returning a 5xx status code.
st, ok := status.FromError(err)
if ok && st.Code() == http.StatusInternalServerError {
if ok && st.Code()/100 == 5 {
failedQueries.Inc()
}
}
Expand Down