ruler: report failed eval on any 5xx status #2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortuman
force-pushed
the
ortuman/ruler/report-failed-eval-on-any-5xx-status-code
branch
from
667435e to
9dd4944
Compare
stevesg
approved these changes
Jun 8, 2022
Contributor
stevesg
left a comment
stevesg
left a comment
There was a problem hiding this comment.
I think this is a useful change, it means we can consider increasing the RulerTooManyFailedQueries alert to critical in order to get coverage of issues with the ruler read path.
replay
approved these changes
Jun 8, 2022
pracucci
approved these changes
Jun 8, 2022
Collaborator
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM (modulo a comment about the CHANGELOG)
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
ortuman
force-pushed
the
ortuman/ruler/report-failed-eval-on-any-5xx-status-code
branch
from
9dd4944 to
ec1ca9f
Compare
pracucci
deleted the
ortuman/ruler/report-failed-eval-on-any-5xx-status-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Ángel Ortuño [email protected]
What this PR does
When remote operational mode is enabled, ruler reports failed rule evaluation metric only when
query-frontendreturns a500status code.This PR adapts it to consider all 5xx status codes.
Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]