-
Notifications
You must be signed in to change notification settings - Fork 11
add option to use the new chunk disk mapper from upstream #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pstream one Signed-off-by: Mauro Stettler <[email protected]>
|
I prefer to keep the |
jesusvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I brought prometheus/main changes into mimir-prometheus I had to add this to a test so that the behaviour would be the same
mimir-prometheus/tsdb/head_test.go
Line 1621 in 51f26e0
| opts.ChunkWriteQueueSize = 1 // We need to set this option so that we use the async queue. Upstream prometheus uses the queue directly. |
That would probably conflict in future merges so lets not forget to leave it the same as in prometheus/main once we're done with this PR.
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
I updated this PR, now the only thing which it does is to add an option to use the new chunk disk mapper. |
pstibrany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (no need to block on my comment)
Signed-off-by: Mauro Stettler <[email protected]>
This removes the
OldChunkDiskMapperwhich we added a few months ago.At the time we added it because we needed a way to disable the chunk write queue and in upstream this wasn't possible. In the meantime upstream has been modified in such a way that the chunk write queue can also be disabled there by passing a size of
0, so we should makemimir-prometheusmatch upstream again.Edit:
I updated this PR, the current description is now this one: #216 (comment)