Skip to content

promtail: Add ActiveTargets method - #5839

Merged
kavirajk merged 2 commits into
mainfrom
add_active_targets_promtail
Apr 11, 2022
Merged

kavirajk merged 2 commits into
mainfrom
add_active_targets_promtail

Conversation

@marctc

@marctc marctc commented Apr 8, 2022 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR adds ActiveTargets method propagating the activate targets of targetManager of
a Promtail instance. This method is useful for grafana-cold-storage/agent#1582 to know
in order to fetch all active targets of a given promtail instance.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@marctc
marctc requested a review from a team as a code owner April 8, 2022 14:20
@CLAassistant

CLAassistant commented Apr 8, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@kavirajk kavirajk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable. LGTM 👍

@kavirajk
kavirajk merged commit 0315102 into main Apr 11, 2022
@kavirajk
kavirajk deleted the add_active_targets_promtail branch April 11, 2022 06:00
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
* Add ActiveTargets method to promtail

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants