Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Add Logs system API endpoints for instance and targets - #1582

Merged
rfratto merged 6 commits into
mainfrom
api_loki
Apr 11, 2022
Merged

rfratto merged 6 commits into
mainfrom
api_loki

Conversation

@marctc

@marctc marctc commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

PR Description

Add HTTP endpoints to fetch active instances and targets for the Logs subsytem.

  • GET /agent/api/v1/logs/instances
  • GET /agent/api/v1/logs/targets

Which issue(s) this PR fixes

Related to #1404

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@marctc
marctc marked this pull request as ready for review April 11, 2022 08:27
@marctc
marctc requested a review from rfratto April 11, 2022 10:02

@rfratto rfratto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rfratto
rfratto merged commit aef0294 into main Apr 11, 2022
@rfratto
rfratto deleted the api_loki branch April 11, 2022 13:44
mattdurham added a commit that referenced this pull request Apr 11, 2022
* Add Logs system API endpoints for instance and targets

* Remove method

* Update CHANGELOG

* Bump loki

* Fix tests and lint
mattdurham added a commit that referenced this pull request Apr 14, 2022
* Initial windows support for certificate store

* Fix linting

* Fix linting

* Clarify message

* staging

* Update check for clientstore closing

* Cleanup and tests

* merge from main

* Fix tests

* udpate import order in agentctl main.go (#1584)

* Improve debug messages on smoke test scrupt (#1553)

Add seconds as unit of time measure when script mentions TEST_DURATION  in smoke test script

* Add Logs system API endpoints for instance and targets (#1582)

* Add Logs system API endpoints for instance and targets

* Remove method

* Update CHANGELOG

* Bump loki

* Fix tests and lint

* Fix tests

* fix author

* Add documentation

* Update changelog

* Changes regarding formatting and minor changes from PR

* Feedback from PR and fixed bug with the update timer not always running

* Update docs/user/configuration/server-config.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Fix linting rule on non windows platforms

* Fix linting rule on non windows platforms

* Fix linting rule on non windows platforms

* Fix linting rule on non windows platforms

* Fix linting rule on non windows platforms

* Allow client certificate to NOT be defined in some cases. Change of configuration to separate client/server blocks

* Refactor naming for linting

* Very rough implementation of credentials

Co-authored-by: matt durham <matt@simplify.dev>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
@github-actions github-actions Bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 29, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants