Skip to content

feat(engine): implement strict and keepEmpty logfmt parsing #19668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 5, 2025
Merged

feat(engine): implement strict and keepEmpty logfmt parsing #19668

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6108ec
feat(engine): implement strict and keepEmpty logfmt parsing
benclive Oct 31, 2025
18a916e
Fix correctness bug
benclive Nov 4, 2025
b8ec89a
Use empty slice instead of nil
benclive Nov 5, 2025
899d2ab
Update main planner test
benclive Nov 5, 2025
58101dc
Add clear for slice reuse
benclive Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/engine/internal/executor/expressions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func newExpressionEvaluator() expressionEvaluator {
}

func (e expressionEvaluator) eval(expr physical.Expression, input arrow.Record) (arrow.Array, error) {

switch expr := expr.(type) {

case *physical.LiteralExpr:
Expand Down
Loading