feat(engine): implement strict and keepEmpty logfmt parsing #19668
+560
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
force-pushed
the
benclive/implement-strict-logfmt-parsing-again
branch
from
4a9e14b to
d9a77fc
Compare
benclive
force-pushed
the
benclive/implement-strict-logfmt-parsing-again
branch
from
3130dd7 to
899d2ab
Compare
chaudum
approved these changes
Nov 5, 2025
| if cap(dst) >= 2 { | ||
| dst = dst[:2] | ||
| if cap(dst) >= 4 { | ||
| dst = dst[:4] |
Contributor
There was a problem hiding this comment.
Do we need to clear out any references in dst[4:]?
Contributor
Author
There was a problem hiding this comment.
Added clear(dst[4:]) to guard against this. Everything under index 4 is explicitly set to a new value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds strict & keepEmpty for logfmt
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/2058
Checklist