Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the docker driver build #15354

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Dec 10, 2024

What this PR does / why we need it:

#9247 did not seem to fix the docker driver build. It first failed because of the an incorrect prefix in the job definition, and after that was fixed it failed again because of an undefined env variable.

Depends on grafana/loki-release#165

Which issue(s) this PR fixes:
Fixes #5682, #15318

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner December 10, 2024 20:11
@pull-request-size pull-request-size bot added size/L and removed size/S labels Dec 10, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 10, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Loki Driver ARM64
2 participants