Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM version of loki plugin not working anymore #15318

Open
francescor opened this issue Dec 9, 2024 · 5 comments
Open

ARM version of loki plugin not working anymore #15318

francescor opened this issue Dec 9, 2024 · 5 comments
Labels
docker Pull requests that update Docker code type/bug Somehing is not working as expected type/build

Comments

@francescor
Copy link

Describe the bug

We've been using the ARM version of the Docker loki plugin, but it does not work anymore

To Reproduce

Steps to reproduce the behavior:

  1. setup brand new ARM "Ubuntu 22.04.5 LTS" with latest docker
  2. execute sudo docker plugin install grafana/loki-docker-driver:latest --alias loki --grant-all-permissions and I get
$ sudo docker plugin install grafana/loki-docker-driver:latest      --alias loki --grant-all-permissions
latest: Pulling from grafana/loki-docker-driver
Digest: sha256:82270b494d8c157f035fde65bc0159076f4c4361b5bb061b4fc817e8db04234a
32dbe5a742d5: Complete 
Error response from daemon: dial unix /run/docker/plugins/f50ab7f3a49b2f1d4c629e8690d1ca5af5cc96522720530f6c2643a319ee5a0b/loki.sock: connect: no such file or directory
$ docker plugin ls 
ID             NAME          DESCRIPTION           ENABLED
f50ab7f3a49b   loki:latest   Loki Logging Driver   false

while if I use dev image created by @tucksaun as in #9247 (comment)
it works

$ docker plugin install tucksaun/loki-docker-driver:main-arm64 --alias loki --grant-all-permissions
main-arm64: Pulling from tucksaun/loki-docker-driver
Digest: sha256:43b6c0d6449bbeacd21e0564ed04a7ef4babb3adcf63c008363096acada5cccf
b959e15d6c4b: Complete 
Installed plugin tucksaun/loki-docker-driver:main-arm64
$ docker plugin ls
ID             NAME          DESCRIPTION           ENABLED
ae02e6d68fe1   loki:latest   Loki Logging Driver   true

Expected behavior

We use cloud-init to create our docker swarm nodes, so nothing changed on our side:
so we would expect the above docker plugin install command would work

Environment:

  • Infrastructure: Docker swarm
  • Swarm nodes with "Ubuntu 22.04.5 LTS"
  • Docker version 27.4.0, build bde2b89

Screenshots, Promtail config, or terminal output
If applicable, add any output to help explain your problem.

@JStickler JStickler added type/build type/bug Somehing is not working as expected docker Pull requests that update Docker code labels Dec 9, 2024
@trevorwhitney
Copy link
Collaborator

trevorwhitney commented Dec 9, 2024

This was fixed in #9247, but that did not make it into our release branch for 3.3.x. I've backported it in, so hopefully this is fixed with the 3.3.2 patch.

@francescor
Copy link
Author

thanks @trevorwhitney

we'll wait for that release: check manually, then put into production, and return our feed here

@trevorwhitney
Copy link
Collaborator

So, fixing this for arm is going to be a lot more involved. After further investigation, while #9247 fixes publishing, the driver build still depends on our build image, which is only being build for amd and arm64 as we have a dependency on trivy which does not appear to build an arm image.

An arm build would require a different version of the build image, or a different Dockerfile to build from. This has likely been broken for arm at least as long as we've had trivy in our build process, if not longer.

@francescor
Copy link
Author

sorry to hear it's not that easy :(

@trevorwhitney difficulties are not clear to me, but it's my lack of knownledge on this.

What I can tell you is that I did not even know the difference between arm and arm64: now I realize the title of this issues is not correct, since our need, indeed, is for the arm64 image of the loki docker plugin (not the arm).

Our context is Docker Swarm (several) running in AWS Ec2. We are migrating our Swarm nodes from

node.platform.arch == x86_64

to

node.platform.arch == aarch64

We are almost there: with great benefits in terms of cpu efficency even if we moved there with the aim to have a lower AWS bill.

All our docker nodes need (and badly), loki :)

We cannot imagine working without it.

@trevorwhitney
Copy link
Collaborator

ok, the arm64 build is in progress of being fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code type/bug Somehing is not working as expected type/build
Projects
None yet
Development

No branches or pull requests

3 participants