Skip to content

fix: reduce lychee retries to avoid compounding GitHub 429s#1215

Merged
zeitlinger merged 3 commits intomainfrom
fix/lychee-retry-config
Mar 13, 2026
Merged

fix: reduce lychee retries to avoid compounding GitHub 429s#1215
zeitlinger merged 3 commits intomainfrom
fix/lychee-retry-config

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

Summary

  • Reduce max_retries from 6 to 2 and increase retry_wait_time from 5s to 10s in lychee config
  • 6 retries with 5s wait compounds GitHub 429 rate limiting — GitHub sees many rapid retries and keeps rate-limiting, causing bot PRs like chore(deps): update dependency npm:renovate to v43.60.5 #1213 to fail lint
  • Fewer retries with longer wait between them is more effective at getting through rate limits

Test plan

  • Verify lint workflow passes on this PR (lychee link check completes without 429 failures)

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger requested a review from jaydeluca as a code owner March 10, 2026 08:26
@martincostello
Copy link
Copy Markdown
Member

Lint is still failing with 429s.

Absolute URLs pointing back to this repo hit GitHub rate limits during
link checking. Convert them to relative paths and add a .lycheeignore
for an external otel link that also triggers 429s.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
Copy link
Copy Markdown
Member Author

Working on a fix upstream in flint (flint#100) — it remaps same-repo URLs to local file paths so the link checker doesn't hit GitHub at all. Once that's released and this repo bumps flint, the 429s should be gone.

Flint v0.8.0 remaps GitHub blob URLs to raw.githubusercontent.com,
avoiding 429 rate limits. Remove .lycheeignore and revert retry
tuning that were workarounds for the same issue.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger merged commit 36275ce into main Mar 13, 2026
12 of 13 checks passed
@zeitlinger zeitlinger deleted the fix/lychee-retry-config branch March 13, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants