Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'enabled' logic of client packages into plugin health check #58

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Sep 21, 2023

This centralises the logic of determining whether each feature of the
plugin is enabled, moving it into the plugin's health check handler.

The /api/plugins/grafana-llm-app/health endpoint will now return
something like this:

{
  "details": {
    "openAI": true,
    "vector": true
  },
  "message": "",
  "status": "OK"
}

We can add further fields as we add more features (e.g. Azure OpenAI
support).

This centralises the logic of determining whether each feature of the
plugin is enabled, moving it into the plugin's health check handler.

The /api/plugins/grafana-llm-app/health endpoint will now return
something like this:

```json
{
  "details": {
    "openAI": true,
    "vector": true
  },
  "message": "",
  "status": "OK"
}
```

We can add further fields as we add more features (e.g. Azure OpenAI
support).
@sd2k sd2k merged commit 21b759a into main Sep 21, 2023
3 checks passed
@sd2k sd2k deleted the improved-health-check branch September 21, 2023 08:16
SandersAaronD pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants