Move 'enabled' logic of client packages into plugin health check #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralises the logic of determining whether each feature of the
plugin is enabled, moving it into the plugin's health check handler.
The /api/plugins/grafana-llm-app/health endpoint will now return
something like this:
```json
{
"details": {
"openAI": true,
"vector": true
},
"message": "",
"status": "OK"
}
```
We can add further fields as we add more features (e.g. Azure OpenAI
support).
This was referenced Sep 21, 2023
Merged
csmarchbanks
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralises the logic of determining whether each feature of the
plugin is enabled, moving it into the plugin's health check handler.
The /api/plugins/grafana-llm-app/health endpoint will now return
something like this:
{ "details": { "openAI": true, "vector": true }, "message": "", "status": "OK" }We can add further fields as we add more features (e.g. Azure OpenAI
support).