Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM: use new health check details in 'enabled' functions #83

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Sep 22, 2023

The health check will be added in version 0.3.0 of the LLM app plugin.

It makes sense to keep the 'enabled' logic in the plugin since we'll have multiple clients in different languages and we don't want them to all have similar logic. Keeping track of the version will be very useful to enable backwards compatibility in this package.

See grafana/grafana-llm-app#58 and grafana/grafana-llm-app#62 for the health check PRs, and #82 for an example of why knowing the
version will be useful.

This will be exposed in the plugin health check from version
0.3.0 onwards, and will be very useful to enable backwards
compatibility in the @grafana/experimental package.

See grafana/grafana-llm-app#62 for the
health check PR and #82 for an example of why knowing the
version will be useful.
@sd2k sd2k marked this pull request as ready for review September 25, 2023 09:53
Copy link
Contributor

@yoziru yoziru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codeincarnate codeincarnate merged commit 708adbb into main Sep 26, 2023
2 checks passed
@sd2k sd2k deleted the use-new-healthcheck branch September 27, 2023 07:33
SandersAaronD pushed a commit that referenced this pull request Jan 10, 2024
LLM: use new health check details in 'enabled' functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants