LLM: use new health check details in 'enabled' functions #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be exposed in the plugin health check from version 0.3.0 onwards, and will be very useful to enable backwards compatibility in the @grafana/experimental package. See grafana/grafana-llm-app#62 for the health check PR and #82 for an example of why knowing the version will be useful.
sd2k
force-pushed
the
use-new-healthcheck
branch
from
4a8c5b5
to
348590b
Compare
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
LLM: use new health check details in 'enabled' functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check will be added in version 0.3.0 of the LLM app plugin.
It makes sense to keep the 'enabled' logic in the plugin since we'll have multiple clients in different languages and we don't want them to all have similar logic. Keeping track of the version will be very useful to enable backwards compatibility in this package.
See grafana/grafana-llm-app#58 and grafana/grafana-llm-app#62 for the health check PRs, and #82 for an example of why knowing the
version will be useful.