Skip to content

fix(ci): drop double release-plz update from release:pr#276

Merged
zeitlinger merged 1 commit intomainfrom
fix/release-plz-no-double-update
May 8, 2026
Merged

fix(ci): drop double release-plz update from release:pr#276
zeitlinger merged 1 commit intomainfrom
fix/release-plz-no-double-update

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

Summary

  • Drop #MISE depends=["release:update"] from .mise/tasks/release/pr.

Why

release-plz release-pr already runs update internally. Chaining release:update as a depends made every CI run bump and regenerate the changelog twice.

Visible symptom: release PR #242 currently shows v0.23.0 with every PR since project start in the changelog. The first successful release-plz run after #274 merged actually computed the right thing — the run log shows:

INFO determining next version for flint 0.21.0
INFO flint: next version is 0.22.0
* flint: 0.21.0 -> 0.22.0

…and then the chained second update (via release-plz release-pr's internal call) bumped 0.22.0 → 0.23.0 on top of an already-bumped tree, regenerating the whole CHANGELOG.

release:update stays available for local manual previews.

After merge

The next push to main should refresh #242 to v0.22.0 with only commits since v0.21.0.

Test plan

  • CI green on this PR
  • After merge, release PR chore: release v0.22.0 #242 retitles to chore: release v0.22.0 and changelog scope shrinks to commits since v0.21.0

release-plz release-pr already runs update internally. Chaining
release:update as a depends made every CI run bump twice and
regenerate the changelog twice, which is why release PR #242
ended up at v0.23.0 with every PR since project start in the
changelog (instead of v0.22.0 with just commits since v0.21.0).

release:update stays available for local manual previews.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger marked this pull request as ready for review May 8, 2026 14:17
Copilot AI review requested due to automatic review settings May 8, 2026 14:17
@zeitlinger zeitlinger requested a review from a team as a code owner May 8, 2026 14:17
@zeitlinger zeitlinger enabled auto-merge (squash) May 8, 2026 14:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the release PR automation task to avoid running release-plz update twice during CI-driven release PR updates.

Changes:

  • Removes the release:update dependency from the .mise release:pr task to prevent a second update run during release-plz release-pr.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .mise/tasks/release/pr
Comment on lines 1 to 4
#!/usr/bin/env bash
#MISE description="Open or update the release PR"
#MISE depends=["release:update"]
#USAGE flag "--git-token <token>" help="GitHub token used by release-plz"

@zeitlinger zeitlinger merged commit b987290 into main May 8, 2026
17 checks passed
@zeitlinger zeitlinger deleted the fix/release-plz-no-double-update branch May 8, 2026 14:23
@github-actions github-actions Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants