ci: pass git-token and forge to release-plz#274
Merged
zeitlinger merged 2 commits intomainfrom May 8, 2026
Merged
Conversation
release-plz 0.3.x requires explicit --git-token and --forge for release/release-pr, otherwise both fail with "git release not configured. Did you specify git-token and forge?". Every release-plz run since #234 has been failing for that reason, leaving release PR #242 stuck on its 2026-04-28 snapshot. Pass the token through as a usage arg from the workflow rather than relying on env-var auto-detection. Extract release:pr from inline mise.toml to its own script so it can forward variadic args the same way release:create already does. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
previously approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release management workflow to accommodate release-plz 0.3.x requiring explicit git authentication/forge parameters, and refactors the release:pr mise task into a standalone task file to support variadic argument forwarding.
Changes:
- Pass
--git-tokenand--forge githubthrough torelease-plz releaseandrelease-plz release-prviamisetask args in the GitHub Actions workflow. - Move
release:prfrom inlinemise.tomltask definition into.mise/tasks/release/pr, mirroring the existing task-file pattern and enabling variadic arg forwarding.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mise.toml |
Removes the inline release:pr task definition in favor of a task file. |
.mise/tasks/release/pr |
Adds a dedicated release:pr task script that forwards variadic args to release-plz release-pr. |
.github/workflows/release-plz.yml |
Updates workflow steps to pass required --git-token / --forge github args to the mise release tasks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Define --git-token as a USAGE flag on release:create and release:pr instead of forwarding via variadic [args]. Validates explicitly and documents the contract; matches Copilot review feedback on #274. Workflow now sets GITHUB_TOKEN in env once per step and passes --git-token "$GITHUB_TOKEN" to mise, instead of duplicating ${{ secrets.GITHUB_TOKEN }} in both env and command. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
approved these changes
May 8, 2026
Closed
2 tasks
zeitlinger
added a commit
that referenced
this pull request
May 8, 2026
## Summary - Drop `#MISE depends=["release:update"]` from `.mise/tasks/release/pr`. ## Why `release-plz release-pr` already runs `update` internally. Chaining `release:update` as a `depends` made every CI run bump and regenerate the changelog **twice**. Visible symptom: release PR [#242](#242) currently shows `v0.23.0` with every PR since project start in the changelog. The first successful release-plz run after [#274](#274) merged actually computed the right thing — the run log shows: ``` INFO determining next version for flint 0.21.0 INFO flint: next version is 0.22.0 * flint: 0.21.0 -> 0.22.0 ``` …and then the chained second `update` (via `release-plz release-pr`'s internal call) bumped 0.22.0 → 0.23.0 on top of an already-bumped tree, regenerating the whole CHANGELOG. `release:update` stays available for local manual previews. ## After merge The next push to `main` should refresh #242 to `v0.22.0` with only commits since `v0.21.0`. ## Test plan - [ ] CI green on this PR - [ ] After merge, release PR #242 retitles to `chore: release v0.22.0` and changelog scope shrinks to commits since `v0.21.0` Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--git-tokenand--forge githubtorelease-plz releaseandrelease-plz release-prfrom the workflow as usage args.release:prfrom inlinemise.tomlto.mise/tasks/release/prso it can forward variadic args the same wayrelease:createalready does.Why
release-plz 0.3.x requires explicit
--git-tokenand--forgefor bothreleaseandrelease-pr. Without them, both fail with:Every release-plz workflow run since #234 has been failing for that reason, leaving release PR #242 stuck on its 2026-04-28 snapshot. After this merges, the next push to
mainwill refresh #242 with all merged commits since.Test plan
mainrefreshes chore: release v0.22.0 #242 with all merged commits + correct version bump (note:#270wasrefactor!so the bump should be a major increment per release-plz semantics)