Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Ignore long-running requests on query-scheduler when checking for high latency. #242

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Ignore long-running requests on query-scheduler when checking for high latency. #242

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c746a7
Ignore long-running requests on query-scheduler when checking for hig…
pstibrany Jan 6, 2021
9d336d7
CHANGELOG.md
pstibrany Jan 6, 2021
842376f
Fix route.
pstibrany Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Cortex / Queries: added bucket index load operations and latency (available only when bucket index is enabled)
- Alerts: added "CortexBucketIndexNotUpdated" (bucket index only) and "CortexTenantHasPartialBlocks"
* [BUGFIX] Honor configured `per_instance_label` in all panels. #239
* [BUGFIX] `CortexRequestLatency` alert now ignores long-running requests on query-scheduler. #242

## 1.6.0 / 2021-01-05

Expand Down
2 changes: 1 addition & 1 deletion cortex-mixin/alerts/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
{
alert: 'CortexRequestLatency',
expr: |||
cluster_namespace_job_route:cortex_request_duration_seconds:99quantile{route!~"metrics|/frontend.Frontend/Process|ready"}
cluster_namespace_job_route:cortex_request_duration_seconds:99quantile{route!~"metrics|/frontend.Frontend/Process|ready|/schedulerpb.SchedulerForFrontend/FrontendLoop|/schedulerpb.SchedulerForFrontend/FrontendLoop"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it repeated twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two different paths on query-scheduler (one for frontend and one for querier), but I included same route twice, instead of two routes. It's fixed now.

>
%(cortex_p99_latency_threshold_seconds)s
||| % $._config,
Expand Down