This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Ignore long-running requests on query-scheduler when checking for high latency. #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
reviewed
Jan 6, 2021
cortex-mixin/alerts/alerts.libsonnet
Outdated
| alert: 'CortexRequestLatency', | ||
| expr: ||| | ||
| cluster_namespace_job_route:cortex_request_duration_seconds:99quantile{route!~"metrics|/frontend.Frontend/Process|ready"} | ||
| cluster_namespace_job_route:cortex_request_duration_seconds:99quantile{route!~"metrics|/frontend.Frontend/Process|ready|/schedulerpb.SchedulerForFrontend/FrontendLoop|/schedulerpb.SchedulerForFrontend/FrontendLoop"} |
There was a problem hiding this comment.
Why is it repeated twice?
There was a problem hiding this comment.
There are two different paths on query-scheduler (one for frontend and one for querier), but I included same route twice, instead of two routes. It's fixed now.
gouthamve
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR updates
CortexRequestLatencyto ignore long-running requests on query-scheduler.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]