chore: bump otel to 128#3843
Conversation
|
Is this a version change that should also be reflected in the main |
|
💻 Deploy preview deleted. |
Updated the markdowns. This PR is only upgrading the dependency and fixes compilation to unblock the profiling PR. The proper upgrade should be handled here #3844 . I don't have capacity to do the proper upgrade. |
| EndpointParams: args.EndpointParams, | ||
| Scopes: args.Scopes, | ||
| TLSSetting: *args.TLSSetting.Convert(), | ||
| TLS: *args.TLSSetting.Convert(), |
There was a problem hiding this comment.
Can you rename args.TLSSetting also to args.TLS?
| { | ||
| name: "push_config and remote_write", | ||
| cfg: ` |
There was a problem hiding this comment.
Why removing this test case?
There was a problem hiding this comment.
it was fragile and incorrect and was testing for wrong thing.
It was supposed to test for an error when push_config and remote_write are configured together.
But in fact (before upgrade to v128) it was receiving a completely different error "empty config for Jaeger receiver".
And the test did check for the presence of error, not the value/type of the error and the test was incorrectly green.
Before v128 the nil map was unmarshaled an empty map and failed validation leading to an error and now after v128 it is unmarshaled as default configuration with no error.
Anyway the tests should be removed because push_config was removed long ago
3 participants
PR Description
Continuation of #3841
Bump otel dependencies from 127 to 128
Which issue(s) this PR fixes
The new otel ebpf profiler PR #2920 requires upgrading to 128.
This PR is only upgrading the dependency and fixes compilation to unblock the above profiling PR. The proper upgrade should be handled here #3844
Notes to the Reviewer
PR Checklist