Conversation
thampiotr
reviewed
Jun 16, 2025
Comment on lines
+158
to
+161
| // todo: allow configuring retries https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/39509 | ||
| RetryMode: awss3exporter.DefaultRetryMode, | ||
| RetryMaxAttempts: awss3exporter.DefaultRetryMaxAttempts, | ||
| RetryMaxBackoff: awss3exporter.DefaultRetryMaxBackoff, |
Contributor
There was a problem hiding this comment.
We will want to expose this in Alloy config and add to documentation.
Similarly, we'll need to go through changelog and ensure we expose all the new functionality or describe any breaking changes.
Contributor
Author
There was a problem hiding this comment.
As far as I understand, the current version of the PR does not change behavior and should not break anything.
Do you mind creating an issue and lets work on this in a followup PR?
thampiotr
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Bump otel dependencies from 126 to 127
Which issue(s) this PR fixes
The new otel ebpf profiler PR #2920 requires upgrading to 128. I intend to submit another bump in a followup to keep the changes smaller and atomic
Notes to the Reviewer
PR Checklist