Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Increase swap space on windows for running tests #1452

Merged
rfratto merged 3 commits into from
Mar 3, 2022
Merged

Increase swap space on windows for running tests #1452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111db7f
increase swap space on windows for running tests
rfratto Mar 2, 2022
0284cca
Try windows-latest
rfratto Mar 2, 2022
b597fe9
Fix ignored tags in bump-formula-pr
rfratto Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/bump-formula-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ on:
push:
tags:
- 'v*'
tags-ignore:
# Ignore release candidates
- 'v*-rc.*'
Comment on lines -8 to -10

@rfratto rfratto Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting some errors about setting both tags and tags-ignore so I'm sneaking in the fix here

- '!v*-rc.*' # Ignore release candidates
jobs:
homebrew-core:
name: homebrew-core
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,18 @@ jobs:
name: Test
strategy:
matrix:
platform: [macos-latest, windows-2019]
platform: [macos-latest, windows-latest]

@rfratto rfratto Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If windows-latest works with the pagefile increase, we probably should just stick to it instead of forcing 2019 IMO

runs-on: ${{ matrix.platform }}
steps:
- name: Increase pagefile
uses: al-cheb/configure-pagefile-action@v1.2
# Tests on Windows can use a lot of memory, and we need to increase the
# pagefile to compensate.
with:
minimum-size: 16GB
maximum-size: 16GB
disk-root: "C:"
if: ${{ matrix.platform == 'windows-latest' }}
- name: Set up Go 1.17
uses: actions/setup-go@v1
with:
Expand Down