This repository was archived by the owner on Jul 28, 2026. It is now read-only.
Increase swap space on windows for running tests - #1452
Merged
Conversation
windows-latest had memory issues more consistently than windows-2019; if this fix works for windows-latest too it's a good sign.
It's invalid to list both tags and ignore-tags, and you have to use the ! syntax to ignore a set of tags instead.
rfratto
commented
Mar 2, 2022
Comment on lines
-8
to
-10
| tags-ignore: | ||
| # Ignore release candidates | ||
| - 'v*-rc.*' |
Contributor
Author
There was a problem hiding this comment.
We were getting some errors about setting both tags and tags-ignore so I'm sneaking in the fix here
rfratto
commented
Mar 2, 2022
| strategy: | ||
| matrix: | ||
| platform: [macos-latest, windows-2019] | ||
| platform: [macos-latest, windows-latest] |
Contributor
Author
There was a problem hiding this comment.
If windows-latest works with the pagefile increase, we probably should just stick to it instead of forcing 2019 IMO
rfratto
enabled auto-merge (squash)
March 3, 2022 00:02
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes our issues 🤷