Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force version upgrade of qdox #9

Merged
merged 1 commit into from
Apr 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ dependencies {
implementation("org.codehaus.plexus:plexus-velocity:1.1.8") {
because("it is needed to generate the help mojo")
}
constraints {
implementation("com.thoughtworks.qdox:qdox") {
version {
require("2.0-M9")
prefer("2.0.0")
}
because("we need the fix for https://github.com/paul-hammant/qdox/issues/43")
}
}

testImplementation("org.spockframework:spock-core:1.3-groovy-2.5")
testFixturesImplementation("junit:junit:4.12")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,23 @@ class MavenPluginDevelopmentPluginFuncTest extends AbstractPluginFuncTest {
result.output.contains("ArtifactIds of the form maven-___-plugin are reserved for plugins of the maven team. Please change the plugin artifactId to the format ___-maven-plugin.")
}

def "works even if weird enums are present"() {
given:
file("src/main/java/TypedEnum.java") << """
import java.util.List;
public enum TypedEnum {
ENUM_VALUE {
private <T> List<T> genericMethod(List<T> list) {
return list;
}
}
}
"""

expect:
run("generateMavenPluginDescriptor")
}

def "generates a plugin and help descriptor for mojos in the main source set"() {
given:
buildFile << """
Expand Down