Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ DO NOT APPROVE: AUT-3665: Demonstrate independent pages approach. #2032

Closed
wants to merge 5 commits into from
Closed

⚠️ DO NOT APPROVE: AUT-3665: Demonstrate independent pages approach. #2032

wants to merge 5 commits into from

Commits on Sep 9, 2024

  1. AUT-3665: Add helper to transform templates for mobile 

    This helper is intended to provide a single mechanism that can be
added to controllers as required. The helper receives the web template
and a boolean reflecting context as arguments. It will returning the
path to the mobile equivalent template where the context is mobile.

The intention is for the helper to reinforce a consistent approach to
introducing mobile templates.
    @gtvj
    gtvj committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    611de44 View commit details
    Browse the repository at this point in the history

  2. AUT-3665: Introduce mobile specific layout 

    This layout will be used by templates that are intended
for presentation within a mobile app. It differs from the
web template because:

- It does not have the header as a link
- It does not have a footer (reflecting the designs for the
  landing page which are included in the Jira ticket).
    @gtvj
    gtvj committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d4227c4 View commit details
    Browse the repository at this point in the history

  3. AUT-3665: Introduce locale block for mobile pages 

    These blocks are intended to keep the content that is included in
templates intended for the mobile context separate to those for the
web context. While this may result in a degree of content redundancy
over the long-term, I have opted for this approach because it:

- Makes it clear to future developers in which context a given piece of
  content is intended to appear
- Reduces complexity when it is necessary to update a page in only the
  mobile or web context, without it being necessary to seek approval from
  the other team
- Allows us to have a clear relationship between the template contexts and
  content blocks. For example, any page within a '/mobile-templates' directory
  should only contain locale referencs to the 'mobilePages' content block.
    @gtvj
    gtvj committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b29c31a View commit details
    Browse the repository at this point in the history

  4. AUT-3665: Add and force render of mobile template. DO NOT MERGE. 

    This commint adds the mobile template and updates the controller to
force it being rendered. This is to demonstrate the condition where
the user session indicates the mobile context (we do not have this
ability yet).
    @gtvj
    gtvj committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    657b1f8 View commit details
    Browse the repository at this point in the history

  5. AUT-3665: Break unit tests to prevent change reaching production 

    Introduces a typographically incorrect quote into a locale file to
prevent this branch from progressing through CI to production (in
the event that the PR is accidentally approved and merged).
    @gtvj
    gtvj committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a1906b6 View commit details
    Browse the repository at this point in the history