⚠️ DO NOT APPROVE: AUT-3665: Demonstrate independent pages approach. #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtvj
force-pushed
the
AUT/3665/demonstrate-approach-1-independent-pages
branch
from
48254a3
to
9673732
Compare
gtvj
changed the title
This helper is intended to provide a single mechanism that can be added to controllers as required. The helper receives the web template and a boolean reflecting context as arguments. It will returning the path to the mobile equivalent template where the context is mobile. The intention is for the helper to reinforce a consistent approach to introducing mobile templates.
gtvj
force-pushed
the
AUT/3665/demonstrate-approach-1-independent-pages
branch
2 times, most recently
from
0a32c06
to
32ec081
Compare
This layout will be used by templates that are intended for presentation within a mobile app. It differs from the web template because: - It does not have the header as a link - It does not have a footer (reflecting the designs for the landing page which are included in the Jira ticket).
These blocks are intended to keep the content that is included in templates intended for the mobile context separate to those for the web context. While this may result in a degree of content redundancy over the long-term, I have opted for this approach because it: - Makes it clear to future developers in which context a given piece of content is intended to appear - Reduces complexity when it is necessary to update a page in only the mobile or web context, without it being necessary to seek approval from the other team - Allows us to have a clear relationship between the template contexts and content blocks. For example, any page within a '/mobile-templates' directory should only contain locale referencs to the 'mobilePages' content block.
This commint adds the mobile template and updates the controller to force it being rendered. This is to demonstrate the condition where the user session indicates the mobile context (we do not have this ability yet).
Introduces a typographically incorrect quote into a locale file to prevent this branch from progressing through CI to production (in the event that the PR is accidentally approved and merged).
gtvj
force-pushed
the
AUT/3665/demonstrate-approach-1-independent-pages
branch
from
32ec081
to
a1906b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Demonstrates how we might implement the independent pages approach set out in the ADR. See Jira ticket for more information.
This is achieved by: