Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Manually passed Cookie header overrides http.CookieJar cookies #599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

masterZSH
Copy link

see issue

@masterZSH
Copy link
Author

move range Jar.Cookies code under range requestHeader

@AllenX2018
Copy link

why is this pr not merged? I think it has fixed #597 @elithrar

@elithrar
Copy link
Contributor

I have not had time to review. Please be patient - this is not a paid for project and is entirely volunteer run.

(Please do not continually @ me)

@AllenX2018
Copy link

I have not had time to review. Please be patient - this is not a paid for project and is entirely volunteer run.

(Please do not continually @ me)

Sorry~ I don’t know that you are so busy, I just want to work with you to better maintain this community. I’m sorry if you bother!

@IngCr3at1on
Copy link

For some reason, I'm confused by the intention here (or perhaps the bug). Wouldn't the manual application of a cookie overriding the jar be desired? Very rarely do I do something manually and expect the automatic behavior to happen; IE: I always expect one or the other, not both.

To that end, while this may address the issue I question if it is the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants