Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Manually passed Cookie header overrides http.CookieJar cookies #16

Conversation

tebruno99
Copy link

Original PR: gorilla#599 by @masterZSH

Fixes: gorilla#597 #15

@tebruno99 tebruno99 self-assigned this Dec 13, 2022
@tebruno99
Copy link
Author

Original Comment: @IngCr3at1on on Sep 8, 2020
For some reason, I'm confused by the intention here (or perhaps the bug). Wouldn't the manual application of a cookie overriding the jar be desired? Very rarely do I do something manually and expect the automatic behavior to happen; IE: I always expect one or the other, not both.

To that end, while this may address the issue I question if it is the desired behavior.

@tebruno99 tebruno99 merged commit aa3e549 into ElasticPerch:bugfix/15-bug-manually-passed-cookie-header-overrides-httpcookiejar-cookies Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant