Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a session middleware issue #508

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: a session middleware issue #508

merged 2 commits into from
Jun 13, 2024

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 12, 2024

πŸ“‘ Description

The session can't be set correctly after req.Next() in Gin and Fiber.

βœ… Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl changed the base branch from master to v1.14.x June 12, 2024 11:03
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.14.x@ab2d51e). Learn more about missing BASE report.

Files Patch % Lines
session/middleware/start_session.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v1.14.x     #508   +/-   ##
==========================================
  Coverage           ?   70.03%           
==========================================
  Files              ?      176           
  Lines              ?    10873           
  Branches           ?        0           
==========================================
  Hits               ?     7615           
  Misses             ?     2690           
  Partials           ?      568           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@hwbrzzl hwbrzzl merged commit c87227d into v1.14.x Jun 13, 2024
8 checks passed
@hwbrzzl hwbrzzl deleted the bowen/fix-session branch June 13, 2024 01:02
hwbrzzl added a commit that referenced this pull request Jun 14, 2024
* fix translation (#507)

* fix: a session middleware issue (#508)

* fix: lang path (#510)

* fix: lang path issue

* remove

* add golang 1.22

* release: v1.14.1
hwbrzzl added a commit that referenced this pull request Dec 20, 2024
…#775)

* feat: [#508] Add Restore method for Orm, to recover soft deleted data

* cancel test

* chore: update mocks

* cancel test

* update mock

* add restoring and restored events

* optimize lint

---------

Co-authored-by: hwbrzzl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant