fix: translation issue #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.14.x #507 +/- ##
========================================
Coverage 70.03% 70.04%
========================================
Files 176 176
Lines 10877 10876 -1
========================================
Hits 7618 7618
+ Misses 2691 2690 -1
Partials 568 568 ☔ View full report in Codecov by Sentry. |
hwbrzzl
force-pushed
the
bowen/fix-translation
branch
from
02862a1 to
d805a32
Compare
hwbrzzl
added a commit
that referenced
this pull request
Jun 14, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 19, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 19, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 19, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 19, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 20, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 20, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 21, 2024
kkumar-gcc
added a commit
that referenced
this pull request
Dec 21, 2024
* add abort method * chore: update mocks * add abort method * chore: update mocks * fix lint * . * chore: update mocks * rename abort response * chore: update mocks * chore: update mocks --------- Co-authored-by: kkumar-gcc <[email protected]>
hwbrzzl
added a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
There is an issue when calling
facades.Lang().SetLocalein middle,facades.Lang().CurrentLocale()still returns the default locale in controller.✅ Checks