Skip to content

runtime:forkAndExecInChild chdir#1140

Merged
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:internal/dir
Jun 6, 2025
Merged

runtime:forkAndExecInChild chdir#1140
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:internal/dir

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Jun 5, 2025

The way Go calls its assembly function libc_chdir_trampoline via rawSyscall ultimately means the assembly itself just ends up calling libc's chdir. So use c.Chdir directly.

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (87c7b65) to head (701568e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          29       29           
  Lines        7343     7343           
=======================================
  Hits         6362     6362           
  Misses        914      914           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luoliwoshang luoliwoshang changed the title internal:forkAndExecInChild chdir runtime:forkAndExecInChild chdir Jun 5, 2025
@xushiwei xushiwei merged commit fc86634 into goplus:main Jun 6, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants