Skip to content

refactor(llcppsigfetch):reuse llgo/preprocessor#426

Merged
MeteorsLiu merged 4 commits intogoplus:mainfrom
luoliwoshang:reuse/preprocess
Jun 6, 2025
Merged

refactor(llcppsigfetch):reuse llgo/preprocessor#426
MeteorsLiu merged 4 commits intogoplus:mainfrom
luoliwoshang:reuse/preprocess

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Jun 5, 2025

  • panic: todo: syscall.forkAndExecInChild1 - dir
package main

import (
	"os/exec"
	"path/filepath"
)

func main() {
	cmd := exec.Command("ls", "-l")
	cmd.Dir = filepath.Dir("./")
	cmd.Run()
}

goplus/llgo#1140

@luoliwoshang luoliwoshang marked this pull request as draft June 5, 2025 10:23
@luoliwoshang luoliwoshang force-pushed the reuse/preprocess branch 3 times, most recently from 5fd4328 to b1853a0 Compare June 6, 2025 03:46
@qiniu-x
Copy link

qiniu-x bot commented Jun 6, 2025

[Git-flow] Hi @luoliwoshang, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

    test with abs path

    test with abs path

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

Details

If you have any questions about this comment, feel free to raise an issue here:

@luoliwoshang luoliwoshang marked this pull request as ready for review June 6, 2025 06:35
@luoliwoshang luoliwoshang requested a review from MeteorsLiu June 6, 2025 07:49
@MeteorsLiu MeteorsLiu merged commit b05a2ab into goplus:main Jun 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants