chore: fix build process #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in googlemaps#4, the build task wasn't run when publishing the package to npm. To fix that, we're adding the build-task to the prepack hook, so it will run before a package is created to be uploaded to npm. Also, since googlemaps#2 and googlemaps#3 should fix the tsc, eslint and prettier tests, this also reenabled the full test-suite for the release task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #4, the build task wasn't run when publishing the package to npm. To fix that, we're adding the build-task to the prepack hook, so it will run before a package is created to be uploaded to npm.
Also, since #2 and #3 should fix the tsc, eslint and prettier tests, this also reenables the full test-suite for the release task.
Fixes #4 🦕