Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get playground to work again #2

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix: get playground to work again #2

merged 3 commits into from
Aug 17, 2023

Conversation

usefulthink
Copy link
Contributor

  • fix package name in example code and ts-config
  • update 'get started' instructions
  • fix export name for UMD builds

@usefulthink
fix: get playground to work again
f0da62d 
 - fix package name in example code and ts-config
 - update 'get started' instructions
 - fix export name for UMD builds
@usefulthink usefulthink mentioned this pull request Aug 16, 2023
Closed
usefulthink added a commit to usefulthink/js-adv-markers-utils that referenced this pull request Aug 17, 2023
@usefulthink
chore: fix build process
1d0d4c8 
As noted in googlemaps#4, the build task wasn't run when publishing the package to npm. To fix that, we're adding the build-task to the prepack hook, so it will run before a package is created to be uploaded to npm.

Also, since googlemaps#2 and googlemaps#3 should fix the tsc, eslint and prettier tests, this also reenabled the full test-suite for the release task.
@usefulthink usefulthink mentioned this pull request Aug 17, 2023
Merged
@amuramoto amuramoto closed this Aug 17, 2023
@amuramoto amuramoto reopened this Aug 17, 2023
amuramoto pushed a commit that referenced this pull request Aug 17, 2023
@usefulthink
chore: fix build process (#5)
7ae422d 
As noted in #4, the build task wasn't run when publishing the package to npm. To fix that, we're adding the build-task to the prepack hook, so it will run before a package is created to be uploaded to npm.

Also, since #2 and #3 should fix the tsc, eslint and prettier tests, this also reenabled the full test-suite for the release task.
@amuramoto amuramoto merged commit 25ffa0d into googlemaps:main Aug 17, 2023
googlemaps-bot pushed a commit that referenced this pull request Aug 17, 2023
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
01b9c15 
### [1.0.1](v1.0.0...v1.0.1) (2023-08-17)

### Bug Fixes

* get playground to work again ([#2](#2)) ([25ffa0d](25ffa0d))

### Miscellaneous Chores

* fix build process ([#5](#5)) ([7ae422d](7ae422d))
* update dependencies ([#3](#3)) ([8908d87](8908d87))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usefulthink @amuramoto