This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Added a merge attribute to join classes with the same name #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to dedupe classes documented across multiple files
|
The test is failing, but I am unable to identify the reason for the failure. I wish there were public unit tests. |
|
FWIW, the test is failing because there are no unit tests for the CI runner to run :) |
|
That's good to know. I thought the tool was broken and wasn't showing me the failing tests. |
|
Could I get any feedback on this pull request? I would like to get it merged. |
|
Anyone?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to dedupe classes that are documented across multiple files. This was targeted to allow for external JS includes in elements.
References:
googlearchive/core-component-page-dev#4
googlearchive/core-component-page#7