Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Make it easier to develop widgets with external JS includes - Fixes #4 #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make it easier to develop widgets with external JS includes - Fixes #4 #11

wants to merge 2 commits into from

Conversation

fearphage
Copy link

This is 2 related changes:

This allows devs to develop elements with external js includes and have them documented easily.

References:

googlearchive/core-component-page#7

@fearphage
removed redundant url property
36d59ee
@fearphage
made developing widgets with external js includes easier
831c220 
added a "js" flag which tells the doc viewer to look for js files named like the html files
added a merge flag which gets passed down to the doc-viewer
@fearphage
Copy link
Author

For reference, lets say I have a pull-request element.

Excerpt from pull-request/index.html

<body unresolved>

  <core-component-page js merge></core-component-page>

</body>

This js flag will cause both pull-request.html and pull-request.js to be used as the sources. The merge flag will cause the number of classes found (via core-doc-viewer) to be 1 (instead of 2) assuming they are both named the same.

@fearphage
Copy link
Author

I believe merge should be the default behavior. I didn't enforce that here to maintain backwards compatibility.

@fearphage
Copy link
Author

Bump. Feedback? Anything?

@fearphage
Copy link
Author

Is the 0.5 branch abandoned?

@fearphage
Copy link
Author

is-this-thing-on

Bueller?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fearphage @googlebot