Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

8/8 master -> stable #135

Merged
merged 16 commits into from
Aug 8, 2013
Merged

8/8 master -> stable #135

merged 16 commits into from
Aug 8, 2013
+143 −441

Commits on Jul 25, 2013

  1. Add support for empty if, similar to bind and repeat.

    John Messerly committed Jul 25, 2013
    Configuration menu
    Copy the full SHA
    f8f58e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2013

  1. remove createBinding

    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    3622464 View commit details
    Browse the repository at this point in the history

  2. whitespace

    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    a0c21e3 View commit details
    Browse the repository at this point in the history

  3. Remove TemplateCloser and better encapsulate templateIteratorTable 

    R=arv
BUG=

Review URL: https://codereview.appspot.com/12286043
    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    d1e1bcc View commit details
    Browse the repository at this point in the history

  4. extract method closeInstanceBindings for TemplateIterator 

    R=arv
BUG=

Review URL: https://codereview.appspot.com/12254045
    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    edd23f6 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #129 from jmesserly/empty-if 

    Add support for empty if, similar to bind and repeat.
    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    75e63f5 View commit details
    Browse the repository at this point in the history

  6. dont overload binding apis for template binding 

    john points out that it's weird for TemplateBinding.node to point to the template iterator.

We don't really have a clear delineation of public vs private API right now, but I agree that the iterator reference should really be private.

I'm not prepared yet to go through and start marking private members with trailing underscores. We had that for a while and it just go really ugly.

Hopefully, once we get all of our semantics nailed down, we can write the spec and the IDL and that will make it clear.

r=arv
BUG=

Review URL: https://codereview.appspot.com/12296043
    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    32d409c View commit details
    Browse the repository at this point in the history

  7. make path in bind(name, model, path) default to empty string 

    I think if we spec'd Node.bind, path would be optional and default to '' (in WebIDL).

I realize this impl is kind of cheating, but I think it's the best current option.

R=arv
BUG=

Review URL: https://codereview.appspot.com/12299043
    @rafaelw
    rafaelw committed Aug 1, 2013
    Configuration menu
    Copy the full SHA
    05fe3fa View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2013

  1. Doc has moved

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    c73ae26 View commit details
    Browse the repository at this point in the history

  2. Correcting urls

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    1d7325d View commit details
    Browse the repository at this point in the history

  3. Doc has moved

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    6d77070 View commit details
    Browse the repository at this point in the history

  4. Moving doc

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    9082317 View commit details
    Browse the repository at this point in the history

  5. Moving node_bind doc

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    1d4a7fc View commit details
    Browse the repository at this point in the history

  6. Updating README to point to new doc pages

    @ebidel
    ebidel committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    18a976c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2013

  1. add tests for empty path on bind 

    R=arv
BUG=

Review URL: https://codereview.appspot.com/12573043
    @rafaelw
    rafaelw committed Aug 6, 2013
    Configuration menu
    Copy the full SHA
    dc7a0e9 View commit details
    Browse the repository at this point in the history

  2. Add Template.clear 

    R=arv

Review URL: https://codereview.appspot.com/12574043
    @rafaelw
    rafaelw committed Aug 6, 2013
    Configuration menu
    Copy the full SHA
    60d98f1 View commit details
    Browse the repository at this point in the history